RFR: 8139228: JFileChooser renders file names as HTML document [v3]

Tejesh R tr at openjdk.org
Wed May 21 06:42:53 UTC 2025


On Tue, 20 May 2025 18:18:51 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/javax/swing/JFileChooser/HTMLFileName.java line 59:
> 
>> 57:                          ComboBox remains in HTML format string, then test PASS.
>> 58:                          If it appears to be in plain text, then test FAILS.
>> 59:                          (Verify for all Look and Feel).
> 
> How do I verify for all Look and Feels?
> 
> The test has to iterate over all L&F, and repeat the same thing for each L&F.
> 
> Ideally, it should be an automated test. However, I'm fine with postponing any efforts to automate the test but I'd like to try to automate it.

`        for (UIManager.LookAndFeelInfo laf : UIManager.getInstalledLookAndFeels()) {
            System.out.println("Test for LookAndFeel " + laf.getClassName());
            UIManager.setLookAndFeel(laf.getClassName());
            PassFailJFrame.builder()
                    .instructions(INSTRUCTIONS)
                    .columns(45)
                    .testUI(HTMLFileName::initialize)
                    .positionTestUIBottomRowCentered()
                    .build()
                    .awaitAndCheck();
            System.out.println("Test passed for LookAndFeel " + laf.getClassName());
        }`
When I try to iterate the test for all L&F, the test result of first L&F is explicitly taken for other L&F too. Any idea why ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24439#discussion_r2099478001


More information about the client-libs-dev mailing list