RFR: 8357176: java.awt javadoc code examples still use Applet API [v3]
Alexey Ivanov
aivanov at openjdk.org
Wed May 21 16:41:55 UTC 2025
On Tue, 20 May 2025 22:09:37 GMT, Phil Race <prr at openjdk.org> wrote:
>> Update the some code examples and accompanying images to no longer mention or display as applets.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>
> 8357176
src/java.desktop/share/classes/java/awt/BorderLayout.java line 98:
> 96: * demonstrating BorderLayout. Each section of the BorderLayout contains a
> 97: * Button corresponding to its position in the layout, one of: North, West,
> 98: * Center, East, or South." style="margin: 7px 10px;">
I'd drop this `style` attribute, too.
src/java.desktop/share/classes/java/awt/FlowLayout.java line 59:
> 57: * <img src="doc-files/FlowLayout-1.png"
> 58: * ALT="Graphic of Layout for Three Buttons"
> 59: * style="margin: 7px 10px;">
I'd drop this `style` attribute. It indents the image by 10 pixels to the right so that it doesn't align to the left edge of the surrounding text.
I see no value in increasing the vertical margins by 7px. Each paragraph has already 14px top/bottom margins.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25278#discussion_r2100738012
PR Review Comment: https://git.openjdk.org/jdk/pull/25278#discussion_r2100737154
More information about the client-libs-dev
mailing list