RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v8]

Alexey Ivanov aivanov at openjdk.org
Thu May 22 14:12:55 UTC 2025


On Thu, 22 May 2025 13:19:43 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> There are some compilation failures noticed in the recently open sourced test javax/swing/JMenuItem/bug6197830.java. The compilation failures are due to missing import statements and a missing dependency file MenuItemTest.java.
>> 
>> Fix: I have added the required import statements and added the code-piece from MenuItemTest.java as a method getMenuItemTestFrame().
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed trailing whitespace

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JMenuItem/MenuItemTest/bug6197830.java line 52:

> 50:                 .testUI(bug6197830::createTestUI)
> 51:                 .position(PassFailJFrame.Position.TOP_LEFT_CORNER)
> 52:                 .positionTestUIBottomRowCentered()

Suggestion:

                .positionTestUIBottomRowCentered()

-------------

PR Review: https://git.openjdk.org/jdk/pull/25319#pullrequestreview-2861403996
PR Review Comment: https://git.openjdk.org/jdk/pull/25319#discussion_r2102665677


More information about the client-libs-dev mailing list