RFR: 8356594: JSplitPane loses divider location when reopened via JOptionPane.createDialog() [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu May 22 16:27:10 UTC 2025


On Thu, 22 May 2025 16:11:12 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Click position fixed..L&F iteration
>
> test/jdk/javax/swing/JSplitPane/TestSplitPaneResetDividerLoc.java line 80:
> 
>> 78:             System.out.println("Testing LAF : " + laf.getClassName());
>> 79:             try {
>> 80:                 setLookAndFeel(laf);
> 
> If setLookAndFeel encounters UnsupportedLookAndFeelException we will output the exception into stdout but we will do the entire test again with the previously installed LAF. Shall we do so? If we consider that exception as non-fatal for the test maybe we can make setLookAndFeel  method boolean instead of void returning true only if it was successfully installed new LAF and skip test iteration if it returns false?

ok..modified..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25294#discussion_r2102961779


More information about the client-libs-dev mailing list