RFR: JDK-8357082 : Stabilize and add debug logs to CopyAreaOOB.java
Sergey Bylokhov
serb at openjdk.org
Thu May 22 19:57:53 UTC 2025
On Thu, 22 May 2025 17:37:42 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> test/jdk/java/awt/Graphics2D/CopyAreaOOB.java line 88:
>>
>>> 86:
>>> 87: private static void createTestUI() {
>>> 88: frame = new Frame();
>>
>> You do not need to call all these methods on the EDT, these are AWT components that should handle multithreaded usage (main/EDT/toolkit threads). It is possible that the issue is only reproducible on macOS due to synchronization problems related to the metal pipeline?
>
> Recent AWT test updates have UI creation wrapped in EDT. I have seen many reviewers recommend using EDT even with AWT components.
>
> Recently came across another PR where EDT is recommended.
> https://github.com/openjdk/jdk/pull/25278#discussion_r2098939094
> https://github.com/openjdk/jdk/pull/25278#discussion_r2100689626
For external use in apps we can recommend it so it will be unified for swing and awt, but for internal use we cannot simply switch to EDT as a cleanup or a bug fix. The code related to awt/2d runs in various threads and must be properly synchronized.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25279#discussion_r2103303179
More information about the client-libs-dev
mailing list