RFR: 8357299: Graphics copyArea doesn't copy any pixels when there is overflow
Alexander Zuev
kizune at openjdk.org
Fri May 23 19:57:55 UTC 2025
On Wed, 21 May 2025 03:17:34 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> Graphics copyArea overflow check bails out of copying pixels if there is overflow.
> The spec says ""If a portion of the source rectangle lies outside the bounds of the component, or is obscured by another window or component, {@code copyArea} *will be unable to copy* the associated pixels"
>
> which suggests that we should always copy the parts inside the bounds and never the parts outside the bounds
> but it seems currently, in the case of overflow it no longer copies any pixels, including the parts that are inside.
> So, the fix clips the copyarea region to clip bounds so it will only affect pixels within the valid bounds, and any pixels outside will be ignored.
Looks good.
-------------
Marked as reviewed by kizune (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25340#pullrequestreview-2865565717
More information about the client-libs-dev
mailing list