RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v24]

Prasanta Sadhukhan psadhukhan at openjdk.org
Wed May 28 03:41:06 UTC 2025


On Tue, 27 May 2025 23:10:11 GMT, Phil Race <prr at openjdk.org> wrote:

> I hope (!) we are on the same page. Let me try and say it so we are ..
> 
>     * WE will always draw a check (tick)  or radio button to show the selected item
> 
Yes, current PR does this..

>     * WE will always reserve space for that tick
>
Yes, current PR does this.
 
>     * WE will never over-write the check/tick with the icon image.
>
Yes, current PR does this.
 
>     * Icon images will never move  (unlike the funky windows case which is the root of all of this)  because we will always reserve space for it.
> 
Yes, icon image has its own space in current PR

>     * If ANY item has an icon image, ALL items reserve the space, even if not used, this is needed for the next item :
> 
>     * Text strings will all align. Always

Current PR doesnt have this..Text string is not aligned for item that doesn't have iconimage with item that does have iconimage. I will fix this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-2914795445


More information about the client-libs-dev mailing list