RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v25]

Prasanta Sadhukhan psadhukhan at openjdk.org
Wed May 28 03:48:03 UTC 2025


> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.

Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 29 additional commits since the last revision:

 - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
 - Review comments fix
 - Expand wildcard imports
 - Remove unneeded methods
 - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
 - Code duplication removed
 - Remove Windows L&F check from BasicMenuItemUI
 - Review comment fix
 - Test rename
 - Revert to non-CSR needed fix
 - ... and 19 more: https://git.openjdk.org/jdk/compare/fad5797e...ba7ecae3

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/23324/files
  - new: https://git.openjdk.org/jdk/pull/23324/files/e20cfc05..ba7ecae3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=23324&range=24
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23324&range=23-24

  Stats: 505436 lines in 6900 files changed: 196150 ins; 275956 del; 33330 mod
  Patch: https://git.openjdk.org/jdk/pull/23324.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23324/head:pull/23324

PR: https://git.openjdk.org/jdk/pull/23324


More information about the client-libs-dev mailing list