RFR: 8355478: DoubleActionESC.java fails intermittently [v2]

Anass Baya abaya at openjdk.org
Wed May 28 13:49:40 UTC 2025


On Thu, 15 May 2025 16:23:34 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Anass Baya has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/jdk/ProblemList.txt
>>   
>>   Co-authored-by: Abhishek Kumar <abhishek.cx.kumar at oracle.com>
>
> test/jdk/java/awt/FileDialog/DoubleActionESC.java line 81:
> 
>> 79:                 robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
>> 80:                 robot.waitForIdle();
>> 81:                 robot.delay(1000);
> 
> Can the delay be reduced to `500`?

Yes, it can be reduced to 500 without impacting the behavior or changing the failure frequency

> test/jdk/java/awt/FileDialog/DoubleActionESC.java line 90:
> 
>> 88: 
>> 89:             latch.await(LATCH_TIMEOUT, SECONDS);
>> 90:             if (fd.isVisible()) {
> 
> I'm on the fence here… Calling `fd.isVisible()` on EDT is more reliable; but it's not strictly required for AWT components.

I have added it. However, as you assumed, it's not required for AWT components, so the test is still failing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25184#discussion_r2111958642
PR Review Comment: https://git.openjdk.org/jdk/pull/25184#discussion_r2111954795


More information about the client-libs-dev mailing list