RFR: 8357799: Improve instructions for JFileChooser/HTMLFileName.java [v2]
Harshitha Onkar
honkar at openjdk.org
Thu May 29 21:29:53 UTC 2025
On Mon, 26 May 2025 17:18:06 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> The instructions for the `javax/swing/JFileChooser/HTMLFileName.java` test are still not as clear.
>>
>> The file name in the instructions is rendered as HTML, which, I believe, is unexpected. It should be displayed as the plain text.
>>
>> The instructions also say about file and directory which have HTML in their name; this was true in the initial version of the test in #24439 that created files and directories on the real file system.
>>
>> The final version of test uses a virtual file system that displays *three files*, there's no way to navigate.
>>
>> I also clarified the instructions: look at how the file name of the first file is rendered in _the file pane_ and _the navigation combo box_ (**Look in** in Metal L&F).
>>
>> In the `VirtualFileSystemView` class, I changed the name of the third file from `virtualFolder` to `virtualFile2.log`, and made the file array a field which ensures `getRoots` and `getFiles` return the same list.
>>
>>
>> In addition to this, I reduced the number of rows allocated for the instructions. Since the instructions are in HTML format, the number of lines of HTML code makes no sense for determining the size.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>
> Correct the title of the test frames
test/jdk/javax/swing/JFileChooser/HTMLFileName.java line 81:
> 79: in the navigation combo box above is displayed
> 80: as HTML, then press <b>Pass</b>.<br>
> 81: If it is in plain text, then press <b>Fail</b>.
According to test instructions it states that the file name in the **file pane** and navigation combo box must be displayed as HTML. When I'm testing with system (Aqua) LaF on macOS the file name in file pane shows up empty (with the original as well as updated test).
<img src="https://github.com/user-attachments/assets/5b78d972-4d2f-41d3-ab6b-c9c4b0a8b767" alt="HTML_Enabled" width=400 height=300 />
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25455#discussion_r2114776660
More information about the client-libs-dev
mailing list