RFR: 8353230: Emoji rendering regression after JDK-8208377 [v4]

Daniel Gredler dgredler at openjdk.org
Fri May 30 00:54:54 UTC 2025


On Fri, 30 May 2025 00:45:36 GMT, Daniel Gredler <dgredler at openjdk.org> wrote:

>> src/java.desktop/share/classes/sun/print/RasterPrinterJob.java line 2485:
>> 
>>> 2483:         for (int i = 0; i < len; i++) {
>>> 2484:             char c = in_chars[i];
>>> 2485:             if (c > '\r' || c < '\t' || c == '\u000b' || c == '\u000c')  {
>> 
>> hmm. looks like you are fixing a bug here. I think those == were supposed to be !=
>
> Hah, I've had to check it a few times but I do think the code was correct -- just formulated in a confusing way, probably as a micro-optimization.

Although I do think we will end up wanting to add Vertical Tab and Form Feed to the list of ignored whitespace chars later, as part of JDK-8356803.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24412#discussion_r2114958892


More information about the client-libs-dev mailing list