RFR: 8357299: Graphics copyArea doesn't copy any pixels when there is overflow

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri May 30 02:10:02 UTC 2025


On Thu, 29 May 2025 23:29:37 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> ok
>
>>That is because down below it anyway calls SurfaceData_IntersectBounds(&dstInfo.bounds, &clipInfo.bounds); 
> so it should clip to clipInfo.bounds there.
> 
> In addition to intersecting dst with clip, you're also intersecting src with clip, which seems incorrect. A better approach might be to compute the drawable width based on the non-overflowing range for both src and dst, and then proceed with the original logic.
> 
> BTW I have not checked MaskBlit_MaskBlit yet it might require a similar update.

We have not found any problem with that part of code so far..We have addressed the issue that was raised.
MaskBlit might require similar update but since it was not proven to be problematic (we waited for your feedback) and since RDP1 is approaching, we will integrate this and you can come back with POC for us to check..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25340#discussion_r2115019947


More information about the client-libs-dev mailing list