RFR: 8355904: Use variadic macros for J2dTrace [v6]

Phil Race prr at openjdk.org
Fri May 30 21:34:52 UTC 2025


On Thu, 22 May 2025 20:44:30 GMT, Nikita Gubarkov <ngubarkov at openjdk.org> wrote:

>> J2dTrace macros have multiple overloads specifying number of arguments, making it less convent to change number of arguments. There were cases when existing macros were not enough and people had to add new variants with even more arguments. We could simply use variadic macros instead.
>> 
>> Also, currently those macros expand to a { code block }, which doesn't require a semicolon at the end, so it can sometimes be missed, leading to an inconsistent code style. We could expand it directly to the function, forcing user to insert a semicolon after that, in a function-like style.
>
> Nikita Gubarkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update D3DShaderGen.c

I would like to run this through our build system - which will build the debug builds as well as product
but I find that a recent change means the patch doesn't apply.
So pls merge the change with latest master and I will try after you've done that

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24949#issuecomment-2923541756


More information about the client-libs-dev mailing list