Integrated: 8358107: Rollback JDK-8357299 changeset

Sat May 31 00:30:02 UTC 2025

On Fri, 30 May 2025 04:11:36 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> The patch for [JDK-8357299](https://bugs.openjdk.org/browse/JDK-8357299) does not completely fix the regression it was intended to address. Instead of bailing out on overflow, it introduces additional logic around src and clip, which might lead to attempts to draw invalid source pixels.
> 
> A test case demonstrating the issue is attached to [JDK-8358103](https://bugs.openjdk.org/browse/JDK-8358103)(passed on jdk22 failed on latest openjdk/jdk).
> 
> There are some unresolved discussions related to that patch, see [PR](https://github.com/openjdk/jdk/pull/25340). I believe it would be better to bail out early in case of overflow than risk incorrect calculations. 
> 
> Therefore, I propose reverting [JDK-8357299](https://bugs.openjdk.org/browse/JDK-8357299) until a proper fix is available. This approach would also simplify backports, since only the patch for [JDK-8358103](https://bugs.openjdk.org/browse/JDK-8358103) would need to be backported
> 
> @prsadhuk, @prrace please take a look

This pull request has now been integrated.

Changeset: d9d00d33
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d9d00d33a6a0d540a10e0a58f6df27cae46d2753
Stats:     74 lines in 2 files changed: 5 ins; 62 del; 7 mod

8358107: Rollback JDK-8357299 changeset

Reviewed-by: psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/25537