RFR: 8358057: Update validation of ICC_Profile header data

Sergey Bylokhov serb at openjdk.org
Sat May 31 01:07:53 UTC 2025


On Fri, 30 May 2025 23:56:35 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>I hadn't noticed it earlier but icAbsoluteColorimetric and icICCAbsoluteColorimetric point to the same intent. Is it good to unify them into a single constant in src code during clean up (separate issue)?

At some point, that constants were renamed in the ICC spec, and as a result, the new constants with the different names were added to ICC_Profile. The old one were not removed to avoid breaking compatibility. It wasn't considered critical, since both constants have the same value.

>Since both indicate intent value of 3 only one comparison should be sufficient in the test.

I just included all constants supported by the JDK for completeness.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25519#discussion_r2116951657


More information about the client-libs-dev mailing list