RFR: JDK-8353755 : Add a helper method to Util - findComponent() [v3]
Alexey Ivanov
aivanov at openjdk.org
Tue Nov 4 14:04:09 UTC 2025
On Tue, 4 Nov 2025 13:46:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> I would even format it like this, wrapping all the chained calls:
>>
>>
>> public static Component findSubComponent(Component parent, String className) {
>> return findComponentImpl((Container) parent,
>> c -> c.getClass()
>> .getName()
>> .contains(className));
>> }
>
> I also suggest calling `findComponent` instead of `findComponentImpl` — then you can remove the line *“Always run this method on the EDT thread”* from the javadoc comment.
>
> Also, change “a sub component” to “a subcomponent”.
> It fails because the code I proposed is plainly wrong.
>
> ```java
> public static Component findSubComponent(Component parent, String className) {
> return findComponentImpl((Container) parent,
> c -> c.getClass().getName().contains(className));
> }
> ```
This time I tested the above code by running the following tests `test/jdk/javax/swing/JFileChooser/FileChooserToolTipTest.java test/jdk/javax/swing/JFileChooser/FCPopupMenuOrientationTest.java` which use `Util.findSubComponent` and the tests passed for me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27944#discussion_r2490642394
More information about the client-libs-dev
mailing list