RFR: JDK-8353755 : Add a helper method to Util - findComponent() [v3]
Harshitha Onkar
honkar at openjdk.org
Wed Nov 5 18:02:26 UTC 2025
On Tue, 4 Nov 2025 13:55:19 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Any reason for updating the test files with this PR ? I feel this PR should be restricted to Util file updates alone, updating the test files can be taken up separately.
>
>> Any reason for updating the test files with this PR ? I feel this PR should be restricted to Util file updates alone, updating the test files can be taken up separately.
>
> This is a valid concern. I tend to agree. The test from which the `findComponent` method is moved to the `Util` class, `javax/swing/JFileChooser/FileSizeCheck.java`, isn't backported to any releases. Yet I expect this change to `Util` would be backported to all the supported releases.
>
> This is why I suggest submitting a new bug to update `FileSizeCheck.java`. (That new bug would be backported to 21u where the test `FileSizeCheck.java` exists.)
>
> Similarly, as [I just mentioned](https://github.com/openjdk/jdk/pull/27944#discussion_r2490547507), it makes sense to update `javax/swing/JFileChooser/bug4759934.java` in its own issue to keep the history clearer. Especially, if we replace all button clicks with programmatic `doClick` instead of using robot.
@aivanov-jdk As suggested I'll be creating separate PRs for test changes.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27944#issuecomment-3492618889
More information about the client-libs-dev
mailing list