RFR: 8366002: Beans.instantiate needs to describe the lookup procedure [v3]
Phil Race
prr at openjdk.org
Tue Oct 7 19:07:16 UTC 2025
On Mon, 29 Sep 2025 14:24:19 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8366002
>
> src/java.desktop/share/classes/java/beans/Beans.java line 81:
>
>> 79: * try to read a serialized object from the resource "x/y.ser" and if
>> 80: * that failed it would try to load the class "x.y" and create an
>> 81: * instance of that class.
>
> Suggestion:
>
> * For example, given a {@code beanName} of {@code "x.y"}, {@code Beans.instantiate} would first
> * try to read a serialized object from the resource {@code "x/y.ser"} and if
> * that failed it would try to load the class {@code "x.y"} and create an
> * instance of that class.
>
> I think the example names of the classes and files should be marked up with `{@code}`. This also applies to `".ser"` in the paragraph above.
I'm not sure that is necessary.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26905#discussion_r2411618029
More information about the client-libs-dev
mailing list