RFR: 8342401: [TESTBUG] javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java test fails in ubuntu 22.04 on SBR Hosts [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Thu Oct 16 02:03:01 UTC 2025
On Thu, 16 Oct 2025 00:17:47 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comment
>
> test/jdk/javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java line 66:
>
>> 64:
>> 65: SwingUtilities.invokeAndWait(() -> {
>> 66: frame = new JFrame(")JSpinnerButtonFocusTest");
>
> Extra bracket in title
rectified
> test/jdk/javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java line 96:
>
>> 94:
>> 95: frame.setAlwaysOnTop(true);
>> 96: frame.pack();
>
> Frame size can be made a little bigger instead of frame.pack().
ok
> test/jdk/javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java line 102:
>
>> 100: robot.waitForIdle();
>> 101: robot.delay(1000);
>> 102:
>
> This is on unedited line: Ln#107, 15 minutes of await time looks really long. I think 1 or 2 mins would be more than sufficient ?
>
>
> if (!latch1.await(15, TimeUnit.MINUTES)) {
> throw new RuntimeException(LF.getClassName() +
> ": Timeout waiting for editor1 to gain focus.");
> }
ok..i noticed it but did not change it as it was not contributing to the failure
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27815#discussion_r2434358520
PR Review Comment: https://git.openjdk.org/jdk/pull/27815#discussion_r2434359485
PR Review Comment: https://git.openjdk.org/jdk/pull/27815#discussion_r2434359308
More information about the client-libs-dev
mailing list