RFR: 8320677: Printer tests use invalid '@run main/manual=yesno

Anass Baya abaya at openjdk.org
Tue Oct 21 17:48:54 UTC 2025


On Tue, 21 Oct 2025 17:24:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The tests : 
>>   test/jdk/java/awt/print/PrinterJob/PolylinePrintingTest.java
>>   test/jdk/java/awt/print/PrinterJob/PageRanges.java      
>>   
>>   were failing because the Argument yesno to 'manual' option is invalid 
>> the fix is as follow : 
>> - Removed yesno
>> - Used PassFailJFrame manual test framework 
>> - add the missing keyboard  'test' to PolylinePrintingTest.java
>
> test/jdk/java/awt/print/PrinterJob/PageRanges.java line 51:
> 
>> 49:     public static void main(String args[]) throws Exception {
>> 50:         PassFailJFrame passFailJFrame = new PassFailJFrame(INSTRUCTIONS);
>> 51:         passFailJFrame.positionTestWindow(null, PassFailJFrame.Position.HORIZONTAL);
> 
> Use `PassFailJFrame.builder()` to configure and create an instance of `PassFailJFrame`.

Hello @aivanov-jdk,
Thank you for your review.
I used this approach to position the instruction window on the left side of the screen so that it won’t be hidden by the print dialog.
Is it possible to do something similar with the PassFailJFrame.builder()?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27916#discussion_r2449192883


More information about the client-libs-dev mailing list