RFR: 8068293: [TEST_BUG] Test closed/com/sun/java/swing/plaf/motif/InternalFrame/4150591/bug4150591.java fails with GTKLookAndFeel

[Prasanta Sadhukhan]

On Thu, 23 Oct 2025 01:06:28 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> > I believe there's always a chance of passing null value to this method from the app since it is public so even if we fix this particular issue somewhere else, there will always be a possibility of getting NPE when null value is passed as highlight and shadow, so this fix is fixing both the gtk issue and border NPE issue
> 
> Maybe, but the updated code would not follow the spec, which requires that the new border use the color parameters for rendering. Instead, it would use "brighter shades of the component's current background color for highlighting, and darker shades for shadows." Also, note that there are several other similar methods that gets the colors, do all of them throw a NPE on null?

It fails for createSoftBevelBorder too..so what do you suggest, update the spec? If it is null, it's quite evident that we will not be using it to obtain brighter shade..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27839#issuecomment-3434775528