RFR: 8150564: Migrate useful ExtendedRobot methods into awt.Robot [v9]
Damon Nguyen
dnguyen at openjdk.org
Thu Oct 23 22:12:40 UTC 2025
On Tue, 7 Oct 2025 15:06:14 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove synchronized keyword
>
> src/java.desktop/share/classes/java/awt/Robot.java line 800:
>
>> 798: * @throws IllegalArgumentException if the {@code buttons} mask contains the mask for
>> 799: * extra mouse button and support for extended mouse buttons is
>> 800: * {@link Toolkit#areExtraMouseButtonsEnabled() disabled} by Java
>
> Suggestion:
>
> * {@linkplain Toolkit#areExtraMouseButtonsEnabled() disabled} by Java
>
> `{@link}` renders in `{@code}` font.
Thanks for the suggestions. Updated.
> src/java.desktop/share/classes/java/awt/Robot.java line 988:
>
>> 986: * A convenience method that simulates typing a char by calling {@code keyPress}
>> 987: * and {@code keyRelease}. Gets the ExtendedKeyCode for the char and calls
>> 988: * type(int keycode).
>
> Suggestion:
>
> * {@link #type(int) type(int keycode)}.
>
> Or
> Suggestion:
>
> * {@code type(int keycode)}.
Went with the second suggestion. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26969#discussion_r2457567902
PR Review Comment: https://git.openjdk.org/jdk/pull/26969#discussion_r2457569319
More information about the client-libs-dev
mailing list