RFR: 8274082 : Wrong test name in jtreg run tag for java/awt/print/PrinterJob/SwingUIText.java [v3]

[Harshitha Onkar]

On Wed, 22 Oct 2025 23:27:19 GMT, Anass Baya <abaya at openjdk.org> wrote:

>> Following issues were fixed in this test
>> 
>> 1. Fixed - Parser error due to yesno in @run main/manual=yesno
>> 2. Fixed Wrong test name specified in @run jtreg
>> 3. @run main/manual=yesno PrintTextTest . It should be @run main/manual=yesno SwingUIText
>> 4. Use PassFailJFrame test framework
>> 5. Enhance Instructions
>> 6. Skip the test if no Printer is available
>
> Anass Baya has updated the pull request incrementally with one additional commit since the last revision:
> 
>    DamonGuy review

LGTM apart from minor suggestions.

test/jdk/java/awt/print/PrinterJob/SwingUIText.java line 32:

> 30:  * @library /test/lib
> 31:  * @build PassFailJFrame
> 32:  * @build jtreg.SkippedException

`@library and @build` tags can be combined as below

Suggestion:

 * @library /java/awt/regtesthelpers /test/lib
 * @build PassFailJFrame jtreg.SkippedException

test/jdk/java/awt/print/PrinterJob/SwingUIText.java line 120:

> 118:         frame.getContentPane().add(panel);
> 119:         frame.pack();
> 120:         frame.setVisible(true);

frame.setVisible(true) for testUI is not required as PFJ takes care of it

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27938#pullrequestreview-3373676508
PR Review Comment: https://git.openjdk.org/jdk/pull/27938#discussion_r2458133865
PR Review Comment: https://git.openjdk.org/jdk/pull/27938#discussion_r2458138029