RFR: 8316274: javax/swing/ButtonGroup/TestButtonGroupFocusTraversal.java fails in Ubuntu 23.10 with Motif LAF

Harshitha Onkar honkar at openjdk.org
Fri Oct 24 22:02:04 UTC 2025


On Fri, 24 Oct 2025 17:07:29 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test began to fail in Ubuntu 23.10. While investigating, I found and filed two new issues:
> 
> * https://bugs.openjdk.org/browse/JDK-8370624 JToggleButton does not display caption if setAction is called
>  e.g. setAction vs addActionListener 
> <img width="287" height="86" alt="image" src="https://github.com/user-attachments/assets/28d24449-e5aa-41fb-a5f1-470ab11d6899" /> vs <img width="287" height="86" alt="image" src="https://github.com/user-attachments/assets/04cdd4ed-6ea4-403c-86c3-f60971d16007" />
> * https://bugs.openjdk.org/browse/JDK-8370627 motif look and feel focus traversal order may vary depending on the system version
> 
> 
> This test fix changes `setAction` to  `addActionListener` and it is to avoid problemlisting the test on Linux.
> 
> Testing looks good.

LGTM apart from minor suggestions (on unchanged lines):

- blockTillDisplayed Ln#177 and Thread.sleep() Ln#184 can be replaced by robot.delay() for a cleaner code
- Frame title "Test" is generic, can be changed to the test name
- toggleButtonActionPerformed, checkboxActionPerformed volatile vars?

-------------

PR Review: https://git.openjdk.org/jdk/pull/27979#pullrequestreview-3379023451


More information about the client-libs-dev mailing list