RFR: 8017266: Background is painted taller than needed for styled text. [v3]

Damon Nguyen dnguyen at openjdk.org
Mon Oct 27 23:00:03 UTC 2025


On Mon, 27 Oct 2025 12:23:35 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> GlyphView.paint() draws background bounding the passed Shape, while the span reserved for the superscripted text is taller than the height of the glyphs so it is better to use the painter.getHeight() instead of alloc.height to fill the actual glyphs boundary
>> 
>> Before fix
>> <img width="103" height="93" alt="image" src="https://github.com/user-attachments/assets/e673d214-13c7-4a42-8f55-cfd654e5a978" />
>> 
>> 
>> With fix
>> <img width="110" height="86" alt="image" src="https://github.com/user-attachments/assets/c13377a6-b4ac-406c-a153-a55c0b9a917b" />
>> 
>> No regressions is observed in CI..A manual verification test is provided..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use width, height

Tested locally and on CI and it looks better with the fix. LGTM.

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/27947#pullrequestreview-3385803088


More information about the client-libs-dev mailing list