RFR: 8370465: Right to Left Orientation Issues with MenuItem Component.

[Alexander Zuev]

On Fri, 24 Oct 2025 04:21:30 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Icon rendering offset is wrong for RTL orientation which is why the icon was not rendered properly..Also, LEADING horizontal text position was not accounted for..
> 
> Before fix
> 
> <img width="386" height="487" alt="image" src="https://github.com/user-attachments/assets/d33140e0-85f1-471c-abf4-bfc7992cd79e" />
> 
> With fix
> 
> <img width="384" height="491" alt="image" src="https://github.com/user-attachments/assets/9df65234-2b84-48ae-b85e-eefdbfbd544e" />

src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java line 918:

> 916:                 }
> 917:                 if (icon != null) {
> 918:                     if (!c.getComponentOrientation().equals(ComponentOrientation.RIGHT_TO_LEFT)) {

Why not just if(c.getComponentOrientation().isLeftToRight()) ? Then you will not need the extra import and the documentation for ComponentOrientation clearly says that direct comparison should be avoided.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27968#discussion_r2471400002