RFR: 8370465: Right to Left Orientation Issues with MenuItem Component [v4]
    Harshitha Onkar 
    honkar at openjdk.org
       
    Thu Oct 30 23:01:17 UTC 2025
    
    
  
On Thu, 30 Oct 2025 02:16:58 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Icon rendering offset is wrong for RTL orientation which is why the icon was not rendered properly..Also, LEADING horizontal text position was not accounted for..
>> 
>> Before fix
>> 
>> <img width="386" height="487" alt="image" src="https://github.com/user-attachments/assets/d33140e0-85f1-471c-abf4-bfc7992cd79e" />
>> 
>> With fix
>> 
>> <img width="384" height="491" alt="image" src="https://github.com/user-attachments/assets/9df65234-2b84-48ae-b85e-eefdbfbd544e" />
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   SwingConstants LEFT and RIGHT fix
Updated fix LGTM apart from minor test suggestions.
test/jdk/javax/swing/JMenuItem/RightLeftOrientation.java line 48:
> 46: /*
> 47:  * @test id=windows
> 48:  * @bug 4211052 8370465
Instead of multiple separate jtreg tags for each LaF we can combine it using `@run` tags as below:
/*
...
...
 * @run main/manual RightLeftOrientation windows
 * @run main/manual RightLeftOrientation motif
 * @run main/manual RightLeftOrientation metal
 */
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27968#pullrequestreview-3401944709
PR Review Comment: https://git.openjdk.org/jdk/pull/27968#discussion_r2479710355
    
    
More information about the client-libs-dev
mailing list