RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v30]

Alexey Ivanov aivanov at openjdk.org
Thu Sep 4 11:29:58 UTC 2025


On Thu, 4 Sep 2025 11:19:10 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Khalid Boulanouare has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 46 additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into jdk-8158801
>>  - Disposes frame at the end of testing.
>>  - Moves latch logic inside ancestor frame block
>>  - Merge branch 'openjdk:master' into jdk-8158801
>>  - Disposes frames after each AWT component test
>>  - Removes redundant code for centring frames
>>  - Merge branch 'openjdk:master' into jdk-8158801
>>  - Merge branch 'openjdk:master' into jdk-8158801
>>  - Centers missed frames in the middle of screen
>>  - Uses KeyboardFocusManager instead of FocusManager
>>  - ... and 36 more: https://git.openjdk.org/jdk/compare/e79df9f1...a62416a9
>
> test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java line 264:
> 
>> 262:                 embedder.setPreferredSize(new Dimension(150, 150));
>> 263:                 container.add(embedder);
>> 264:                 if(container instanceof Window){
> 
> Suggestion:
> 
>                 if (container instanceof Window){

I didn't notice the missing space before the opening brace:

if (container instanceof Window) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2321731571


More information about the client-libs-dev mailing list