RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v31]
Alexey Ivanov
aivanov at openjdk.org
Thu Sep 4 11:30:02 UTC 2025
On Thu, 4 Sep 2025 11:24:53 GMT, Khalid Boulanouare <duke at openjdk.org> wrote:
>> Many Mixing tests failed because the work around click lands on the minimizing area in the window control and causes the tests to fail.
>>
>> This fix changes the width of base frames which allows most of tests to pass.
>
> Khalid Boulanouare has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 47 additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into jdk-8158801
> - Merge branch 'openjdk:master' into jdk-8158801
> - Disposes frame at the end of testing.
> - Moves latch logic inside ancestor frame block
> - Merge branch 'openjdk:master' into jdk-8158801
> - Disposes frames after each AWT component test
> - Removes redundant code for centring frames
> - Merge branch 'openjdk:master' into jdk-8158801
> - Merge branch 'openjdk:master' into jdk-8158801
> - Centers missed frames in the middle of screen
> - ... and 37 more: https://git.openjdk.org/jdk/compare/f4bbc310...54087fa9
test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 55:
> 53:
> 54: protected boolean multiFramesTest = true;
> 55: /**
Suggestion:
protected boolean multiFramesTest = true;
/**
Leave a blank line between members of a class, especially if the members aren't closely related or have comments.
test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 179:
> 177:
> 178: clickAndBlink(robot, lLoc);
> 179: if(ancestor != null && multiFramesTest){
Suggestion:
if (ancestor != null && multiFramesTest) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2321736151
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2321732936
More information about the client-libs-dev
mailing list