RFR: 8366844: Update and automate MouseDraggedOriginatedByScrollBarTest.java [v4]
Damon Nguyen
dnguyen at openjdk.org
Fri Sep 5 18:45:59 UTC 2025
On Thu, 4 Sep 2025 08:20:05 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comment edits
>
> test/jdk/java/awt/List/MouseDraggedOriginatedByScrollBarTest.java line 131:
>
>> 129: for (int i = 0; i < 30; i++) {
>> 130: robot.mouseMove(loc.x, loc.y + 1);
>> 131: }
>
> Suggestion:
>
> for (int i = 0; i < 30; i++) {
> robot.mouseMove(loc.x, loc.y + i);
> }
>
> I forgot to replace `1` with `i` in my earlier suggestion.
>
> This for-loop depends on the fact that `loc` contains the initial location for dragging the mouse. That is, the initial `robot.mouseMove` has to have arguments `(loc.x, loc.y)`, otherwise the mouse jumps `(+10, -20)` pixels.
Thanks! Still worked, but this is the correct intention so I updated it as suggested.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26636#discussion_r2325800849
More information about the client-libs-dev
mailing list