RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v10]
ScientificWare
duke at openjdk.org
Sun Sep 7 12:52:15 UTC 2025
On Mon, 25 Aug 2025 13:08:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> ScientificWare has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge master
>> - JDK-8314731 : Remove all indentations accidentally introduced by the previous commit.
>> - Merge master
>> - Merge master
>> - jdk-8314731 : FormView Alt Support.
>>
>> FormView.java :
>> - revert ALL unrelated changing to formatting.
>>
>> bug8314731.java :
>> - Fix the test description.
>> - Change where the user interface is created.
>> - Add a finall block to be sure the Frame is disposed.
>> - Replace "testPassed" with "testFailed".
>> - Merge master
>> - Replaces this title with "alt attribute test in HTML image type input".
>>
>> Moves this test to /jdk/test/jdk/javax/swing/text/html.
>> - bug8314731.java : Corrects the CopyRight date.
>> - FormView.java :
>> Removes a whitespace
>>
>> bug8314731.java :
>> Adds a newline at end of file.
>> - getMaximumSpan(int axis) method
>> doc -> Not used
>>
>> mouseReleased(MouseEvent evt) method
>> elem and hdoc -> not used
>> return -> could be removed, method returns void
>>
>> loadElementDataIntoBuffer(Element elem, StringBuilder buffer) method
>> value != null -> name can't be null at this point
>>
>> getInputElementData(AttributeSet attr) method
>> value = null -> Already set at null
>> - ... and 15 more: https://git.openjdk.org/jdk/compare/69e664de...9b423808
>
> test/jdk/javax/swing/text/html/bug8314731.java line 50:
>
>> 48: private static boolean testPassed;
>> 49: private static JFrame jf;
>> 50: private static JEditorPane jEditorPane;
>
> Suggestion:
>
> private static JFrame frame;
> private static JEditorPane editorPane;
>
> I prefer not to have `j` from `JFrame` or `JEditorPane` in the name of a field, it doesn't add anything; `frame` is more descriptive than `jf`.
Addressed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15319#discussion_r2328670793
More information about the client-libs-dev
mailing list