RFR: 8162380: [TEST_BUG]Failed the case just press the "fail" button on other platform except linux.

[Alexey Ivanov]

On Tue, 9 Sep 2025 06:55:27 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Test was made to fail due to presence of only "Fail" button instead of both "Pass" and "Fail".
> 
> Modified the test to use PFJ and also clarified the instruction for Windows and Linux

test/jdk/java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java line 46:

> 44:                 Please check if Alt-Gr key is present on keyboard.
> 45:                 If not present, press Pass.
> 46:                 Window :-

Suggestion:

                On Windows:


There should be no space before colon… in English punctuation.

test/jdk/java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java line 49:

> 47:                     Press Alt-Gr or Right Alt key and simulataneously
> 48:                         perform mouse click on the "TestWindow".
> 49:                 Linux :-

Suggestion:

                On Linux:

test/jdk/java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java line 51:

> 49:                 Linux :-
> 50:                     Navigate to
> 51:                       System Settings-> Keyboard-> Shortcuts->Typing.

Suggestion:

                      System Settings-> Keyboard-> Shortcuts-> Typing.

Be consistent.

test/jdk/java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java line 53:

> 51:                       System Settings-> Keyboard-> Shortcuts->Typing.
> 52:                     Select an option for the Alternative Characters Key
> 53:                         For example. Right Alt

The instructions are still unclear to me. There's no **Shortcut** settings in GNOME in Ubuntu 22.04.

There is, however, **Keyboard Shortcuts** section with **View and customise shortcuts**. In the popup, there's a **Typing** section, but there's nothing like alternative keys.

On the main **Keyboard** settings screen, there's an option **Alternate Characters Key**, it's set to **Layout default** in my settings. Is this the option to change?


The original instructions make the tester *click twice*: before changing an option in the settings and after doing so. The new instructions ask to change the setting only.

test/jdk/java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java line 75:

> 73:         mainFrame.addMouseListener(new MouseAdapter() {
> 74:            @Override
> 75:             public void mousePressed(MouseEvent e) {

Suggestion:

            @Override
            public void mousePressed(MouseEvent e) {

Correct the indentation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27162#discussion_r2332952808
PR Review Comment: https://git.openjdk.org/jdk/pull/27162#discussion_r2332953456
PR Review Comment: https://git.openjdk.org/jdk/pull/27162#discussion_r2332955194
PR Review Comment: https://git.openjdk.org/jdk/pull/27162#discussion_r2332996463
PR Review Comment: https://git.openjdk.org/jdk/pull/27162#discussion_r2332997611