RFR: 8162380: [TEST_BUG] MouseEvent/.../AltGraphModifierTest.java has only "Fail" button [v2]

Alexander Zvegintsev azvegint at openjdk.org
Tue Sep 9 20:58:27 UTC 2025


On Tue, 9 Sep 2025 11:53:28 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Test was made to fail due to presence of only "Fail" button instead of both "Pass" and "Fail".
>> 
>> Modified the test to use PFJ and also clarified the instruction for Windows and Linux
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Clarify instruction

test/jdk/java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java line 47:

> 45:                 If not present, press Pass.
> 46:                 On Windows:
> 47:                     Press Alt-Gr or Right Alt key and simulataneously

Suggestion:

                    Press Alt-Gr or Right Alt key and simultaneously

test/jdk/java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java line 52:

> 50:                     Navigate to
> 51:                       System Settings-> Keyboard-> Special Character Entry
> 52:                     Select "Right Alt" option for the "Alternative Characters Key"

Suggestion:

                    Select "Right Alt" option for the "Alternate Characters Key"


I guess we should add instructions for a test user to turn the setting back to default, or skip the test if their system does not have such a setting.

We also use the `forcePass/forceFail` approach:
* The test user may not have a chance to read the instructions all the way through if they are just following them.
* If the user accidentally presses a mouse button with the wrong or missing modifier, there is no way to retry.

So maybe we should add `logArea` and print theresults there, to allow the test user to make several attempts, and read the instructions till the end.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27162#discussion_r2334720398
PR Review Comment: https://git.openjdk.org/jdk/pull/27162#discussion_r2334723940


More information about the client-libs-dev mailing list