RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java [v5]

Srinivas Mandalika smandalika at openjdk.org
Wed Sep 10 11:01:50 UTC 2025


On Mon, 8 Sep 2025 08:42:35 GMT, Srinivas Mandalika <smandalika at openjdk.org> wrote:

>> The java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java test uses object monitors and wait/notify to synchronise actions in the test.
>> 
>> Using CountDownLatch could make the test simpler, shorter, clearer.
>> Tested the code on a windows-x64, macos-x64 and lnux-x64 machines and the test is working as expected.
>
> Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review Feedback: simplified test failure conditions.

Removed the passed & eventType variable for test pass/fail assertion.
Tweaked to assert test scenario only on based on latch.
Removed boiler plate code for mouse Move & Click.

I have incorporated the review suggestions. Can anyone provide feedback on these?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26471#issuecomment-3274430749


More information about the client-libs-dev mailing list