RFR: 8366852: java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java test is failing [v2]

[Alexander Zvegintsev]

On Thu, 11 Sep 2025 05:17:16 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> test/jdk/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java line 57:
> 
>> 55:     private volatile boolean wheelMoved = false;
>> 56:     private volatile boolean frameExited = false;
>> 57:     private final Choice choice = new Choice();
> 
> WHy not do the initialization in EDT in constructor?

It is already on EDT, but moved to the constructor.

> Is there any need to have dependancy on Util..we can use EventQueue directly, right? That will help in running standalone too!!

It was already there, so I decided to use it. It greatly reduce the code amount.

> Also jtreg tags is not aligned with asterisks and author tag not removed||

updated

> test/jdk/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java line 121:
> 
>> 119: 
>> 120:         // mouse wheel doesn't work for the choice on X11 and Mac, so skip it
>> 121:         if (!isXtoolkit && !isLWCToolkit) {
> 
> Is this block required? As in the description it is mentioned that the wheel rotation is taken care for macos down below and it seems test works ok without this block too..

This is a different case that only works on Windows. When the mouse cursor is above the choice, you should be able to change the items using the mouse wheel.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27161#discussion_r2341215416
PR Review Comment: https://git.openjdk.org/jdk/pull/27161#discussion_r2341222995
PR Review Comment: https://git.openjdk.org/jdk/pull/27161#discussion_r2341208632