RFR: 8365379: SU3.applyInsets may produce wrong results [v6]

[Sergey Bylokhov]

On Thu, 11 Sep 2025 03:51:52 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the insets calculation, similar calculation observed in **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified code
>> 
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated summary

src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java line 558:

> 556:     static void applyInsets(Rectangle rect, Insets insets, boolean leftToRight) {
> 557:         if (insets != null) {
> 558:             Insets newInsets = new Insets(insets.top, (leftToRight ? insets.left : insets.right),

Maybe we can eliminate the creation of a new object on each paint event? Since neither method is part of the public API, how about changing the signature of SwingUtilities3.applyInsets and removing the corresponding method in SynthGraphicsUtils?"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27157#discussion_r2342815514