RFR: 8365379: SU3.applyInsets may produce wrong results [v6]
Alexey Ivanov
aivanov at openjdk.org
Fri Sep 12 18:56:14 UTC 2025
On Thu, 11 Sep 2025 03:51:52 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:
>> Hi Reviewers,
>>
>> I have updated the insets calculation, similar calculation observed in **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified code
>>
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>
> Updated summary
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/SwingUtilities/8365379/bug8365379.java line 1:
> 1: /*
Since this test has nothing to do with the public API of `javax.swing.SwingUtilities`, it should reside in the folder structure that corresponds to `com/sun/java/swing/SwingUtilities3.java`, I propose `test/jdk/com/sun/java/swing/SwingUtilities3/ApplyInsetsTest.java`.
We no longer create directories for each test and give meaningful names to test files rather than `bug####.java`.
-------------
PR Review: https://git.openjdk.org/jdk/pull/27157#pullrequestreview-3218340900
PR Review Comment: https://git.openjdk.org/jdk/pull/27157#discussion_r2345160797
More information about the client-libs-dev
mailing list