RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v38]

[Khalid Boulanouare]

On Thu, 4 Sep 2025 18:26:59 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Khalid Boulanouare has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removes MULTI_FRAME_TEST instance variable and cleans up code
>
> test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 73:
> 
>> 71:         return true;
>> 72:     }
>> 73:     public SimpleOverlappingTestBase() {
> 
> Suggestion:
> 
>     }
> 
>     public SimpleOverlappingTestBase() {
> 
> 
> Ensure there's a blank line around method declarations. (For modified / added methods.)

Done.

> test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 173:
> 
>> 171:                 if (!await) {
>> 172:                     throw new RuntimeException("Ancestor frame didn't receive " +
>> 173:                             "focus");
> 
> Suggestion:
> 
>                     throw new RuntimeException("Ancestor frame didn't receive focus");
> 
> 
> I'm for breaking the rule of fitting into 80-column limit, wrapping this line doesn't improve readability.

Done.

> test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 184:
> 
>> 182:             if (ancestor != null && isMultiFramesTest()) {
>> 183:                 ancestor.dispose();
>> 184:             }
> 
> These four lines are indented inconsistently, the indentation should be reduced by four spaces.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2348215286
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2348215908
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2348216383