RFR: 6850365: closed/java/awt/Focus/ActivateFocusTest/ActivateFocusTest.html fails

Phil Race prr at openjdk.org
Mon Sep 15 17:18:02 UTC 2025


On Thu, 11 Sep 2025 10:02:59 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Test is made more robust by executing in EDT and cleanup done by frame dispose. Testing result is green.

Changes requested by prr (Reviewer).

test/jdk/java/awt/Focus/ActivateFocusTest.java line 57:

> 55:             boolean testFailed = false;
> 56:             for (int i = 0; i < NUM_FRAMES; i++) {
> 57:                 testFailed = (af[i].lw.focusCounter > 1);

I don't understand this code. If the first one fails, and the second one passes it will pass the test when I presume it should have failed it.

-------------

PR Review: https://git.openjdk.org/jdk/pull/27214#pullrequestreview-3225590801
PR Review Comment: https://git.openjdk.org/jdk/pull/27214#discussion_r2349633790


More information about the client-libs-dev mailing list