RFR: 8365379: SU3.applyInsets may produce wrong results [v7]

Renjith Kannath Pariyangad rkannathpari at openjdk.org
Tue Sep 16 07:04:03 UTC 2025


On Mon, 15 Sep 2025 15:18:53 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moved test position based on suggesion
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java line 557:
> 
>> 555: 
>> 556:     static void applyInsets(Rectangle rect, Insets insets, boolean leftToRight) {
>> 557:         if (insets != null) {
> 
> No need for null-check here, it's present in the called method.

I have removed null check from both callers and kept this as it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27157#discussion_r2351117837


More information about the client-libs-dev mailing list