RFR: 8365379: SU3.applyInsets may produce wrong results [v11]
Renjith Kannath Pariyangad
rkannathpari at openjdk.org
Tue Sep 16 13:28:42 UTC 2025
On Tue, 16 Sep 2025 10:20:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removed null check and fixed alignment
>
> test/jdk/com/sun/java/swing/SwingUtilities3/ApplyInsetsTest.java line 46:
>
>> 44: rect.height - (insets.top + insets.bottom));
>> 45:
>> 46: SwingUtilities3.applyInsets(rect, insets);
>
> I suggest adding a test for `leftToRight = false` too.
Updated test for covering this
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27157#discussion_r2352498522
More information about the client-libs-dev
mailing list