RFR: 8366369: Add @requires linux for GTK L&F tests [v2]
Sergey Bylokhov
serb at openjdk.org
Tue Sep 16 21:54:57 UTC 2025
On Tue, 16 Sep 2025 13:05:16 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> * Add ~~`@requires os.family == "linux"`~~ `@requires (os.family != "windows" & os.family != "mac")` to prevent GTK L&F tests from running on ~~other OS but Linux~~ non-Unix-like OS.
>> * ~~Let any exceptions from `UIManager.setLookAndFeel` propagate~~ Throw `jtreg.SkippedException` if `UIManager.setLookAndFeel` fails.
>> * Remove `@author` tag.
>> * Expand imports in `test/jdk/com/sun/java/swing/plaf/gtk/Test6635110.java`.
>> * Add leading asterisks to jtreg comment block.
>
> Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Clean up
>
> Declare paint method private, it's not overridden;
> Sort modifiers 'static final'; add @Override to run().
> - Require !(windows or mac) instead of linux
>
> Throw SkippedException if GTK L&F fails to install
> - Merge master
> - 8366369: Add @requires linux for GTK L&F tests
Marked as reviewed by serb (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/26995#pullrequestreview-3231817823
More information about the client-libs-dev
mailing list