RFR: 8367867: [macosx] Ignorable whitespace in text not removed when printing [v2]
Phil Race
prr at openjdk.org
Wed Sep 17 17:24:22 UTC 2025
On Wed, 17 Sep 2025 14:47:49 GMT, Daniel Gredler <dgredler at openjdk.org> wrote:
>> src/java.desktop/share/classes/sun/print/RasterPrinterJob.java line 2479:
>>
>>> 2477: * don't have to worry about platform or font specific handling of them.
>>> 2478: */
>>> 2479: public String removeControlChars(String s) {
>>
>> Perhaps the commend on this method could be updated too, since the method became `public`?
>
> Done, thanks!
You have removed the only override, and the method does nothing with anything except the provided string.
So it seems to me this could be a static utility method, like isIgnorableWhitespace.
I'm not suggesting moving it, just making it static.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27345#discussion_r2356217545
More information about the client-libs-dev
mailing list