RFR: 8367376: Bad ButtonUI prevents other components from updating when system changes desktop properties [v4]

Jeremy Wood jwood at openjdk.org
Mon Sep 22 17:05:02 UTC 2025


On Thu, 18 Sep 2025 06:52:28 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> src/java.desktop/share/classes/sun/swing/plaf/DesktopProperty.java line 222:
>> 
>>> 220:                         setUpdatePending(false);
>>> 221:                     }
>>> 222:                 }
>> 
>> I guess same thing we need to do here too
>> 
>> https://github.com/openjdk/jdk/blob/c96d09acd95d0ccf2fef50b8ccfeb5e2a0aa0968/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L2293-L2296
>
> and here too
> 
> https://github.com/openjdk/jdk/blob/c96d09acd95d0ccf2fef50b8ccfeb5e2a0aa0968/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java#L911-L914

OK, I updated Metal and Synth L&F.

The test in this PR does not currently test either of these new changes, though. Normally I'd feel nervous about that, but IMO the changes in this PR are acceptably low-risk.

Does anyone disagree? If so: should I split this into 2-3 separate tickets/PRs? The original steps involved the Windows L&F and changing the OS's accessibility contrast settings; I don't know if those steps affect Metal/Synth L&F's at all.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27205#discussion_r2369442965


More information about the client-libs-dev mailing list