RFR: 8273617: UninitializedDisplayModeChangeTest.java times out on macOS 12 [v3]
Phil Race
prr at openjdk.org
Mon Sep 22 18:22:26 UTC 2025
On Sun, 21 Sep 2025 11:43:28 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Test used to timeout even though it seems the test passed..Increased the timeout to a safe value as sometimes it shows elapsed time to timeout > 300secs in macOS in CI and also ensured the wait-time for child process to execute the test is not been waiting endlessly.
>> Also ensured the original display mode is resetted after the test to prevent affecting following tests.
>>
>> Tried 100 iterations of the fix on all platforms which is ok
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove displayMode reset
Marked as reviewed by prr (Reviewer).
test/jdk/java/awt/FullScreen/UninitializedDisplayModeChangeTest/DisplayModeChanger.java line 59:
> 57: });
> 58: try {
> 59: Thread.sleep(1000);
Usually I would do Robot.waitForIdle() and then Robot.delay(1000)
But if you say it passed 50 times, then maybe this is enough.
-------------
PR Review: https://git.openjdk.org/jdk/pull/27365#pullrequestreview-3254462727
PR Review Comment: https://git.openjdk.org/jdk/pull/27365#discussion_r2369748802
More information about the client-libs-dev
mailing list