RFR: 8367384: The ICC_Profile class may throw exceptions during serialization [v3]

Sergey Bylokhov serb at openjdk.org
Thu Sep 25 03:12:17 UTC 2025


> Additional checks were recently added to ICC_Profile (see [JDK-8347377](https://bugs.openjdk.org/browse/JDK-8347377)). As a result, objects previously stored as valid profiles may now throw an IllegalArgumentException during serialization. Discussion about serialization was started in https://github.com/openjdk/jdk/pull/23044 but it seems at the end non-serialization related check was [verified](https://github.com/openjdk/jdk/pull/23044/commits/a5201b5f353e8957a1274261372496768edbc7a2). =(
> 
> The patch itself is simple, but I found that we do not have good test coverage in this area. So I added two tests to cover all possible variants specified by the serialization spec.

Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'openjdk:master' into JDK-8367384
 - Add naming conventions used in test file names
 - sort catch
 - Update ValidateICCHeaderData.java
 - 8367384: The ICC_Profile class may throw exceptions during serialization

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/27326/files
  - new: https://git.openjdk.org/jdk/pull/27326/files/d0b44847..251d414b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=27326&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=27326&range=01-02

  Stats: 140661 lines in 1233 files changed: 121116 ins; 11486 del; 8059 mod
  Patch: https://git.openjdk.org/jdk/pull/27326.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/27326/head:pull/27326

PR: https://git.openjdk.org/jdk/pull/27326


More information about the client-libs-dev mailing list