RFR: 8368606: Printer lookup returns empty on AIX platform due to uninitialized results list [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Sep 26 07:56:36 UTC 2025


On Thu, 25 Sep 2025 11:23:18 GMT, Ravi-Patel8 <duke at openjdk.org> wrote:

>> Bug Ref: https://bugs.openjdk.org/browse/JDK-8368606
>> 
>> As part of [JDK-8344057](https://bugs.openjdk.org/browse/JDK-8344057) ("Remove doPrivileged calls from unix platform sources in the java.desktop module"), changes were made to execCmd() in
>>  `src/java.desktop/unix/classes/sun/print/PrintServiceLookupProvider.java`.
>> In the updated implementation, execCmd(...) code is missing to initialize the results variable. It declares it as null and then tries to results.add(line), which prevents the results list from being populated with printer names.
>> 
>> Initializing the results variable will resolve the issue.
>> 
>> 
>> Signed-off-by: Ravi.Patel8 <Ravi.Patel8 at ibm.com>
>
> Ravi-Patel8 has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Updated Comments
>    
>    Signed-off-by: Ravi.Patel8 <Ravi.Patel8 at ibm.com>
>  - Add catch block to log exception details for troubleshooting printer
>    command
>    
>    Signed-off-by: Ravi.Patel8 <Ravi.Patel8 at ibm.com>

src/java.desktop/unix/classes/sun/print/PrintServiceLookupProvider.java line 887:

> 885:             } catch (Exception e) {
> 886:                 // Print exception for tracking printer command errors
> 887:                 System.err.println(e);

Dont think we use println directly...you can use `IPPPrintService.debug_println` instead in my opinion

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27482#discussion_r2381244112


More information about the client-libs-dev mailing list