RFR: 8366002: Beans.instantiate needs to describe the lookup procedure [v2]

Phil Race prr at openjdk.org
Fri Sep 26 19:23:10 UTC 2025


On Mon, 25 Aug 2025 20:09:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - 8366002
>>  - 8366002
>
> src/java.desktop/share/classes/java/beans/Beans.java line 71:
> 
>> 69:      * <p>
>> 70:      * The given name can indicate either a serialized object or a class.
>> 71:      * We first try to treat the beanName as a serialized object
> 
> Suggestion:
> 
>      * We first try to treat the {@code beanName} as a serialized object
> 
> Should this be marked up as it refers the parameter name? Also, in other instances.

done

> src/java.desktop/share/classes/java/beans/Beans.java line 78:
> 
>> 76:      * We then try to load a serialized object from that resource.
>> 77:      * <p>
>> 78:      * For example, given a beanName of "x.y", Beans.instantiate would first
> 
> Suggestion:
> 
>      * For example, given a beanName of "x.y", {@code Beans.instantiate} would first
> 
> Method names should be marked up.

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26905#discussion_r2383275383
PR Review Comment: https://git.openjdk.org/jdk/pull/26905#discussion_r2383275103


More information about the client-libs-dev mailing list