RFR: 8305915: java/awt/Frame/FrameLocation/FrameLocation.java fails with "The frame location is wrong!" [v2]

Alexey Ivanov aivanov at openjdk.org
Mon Sep 29 16:02:53 UTC 2025


On Tue, 23 Sep 2025 07:46:23 GMT, Tejesh R <tr at openjdk.org> wrote:

>> The test passed on CI machines with multiple test runs. Few stabilization fix has been made to make the test more robust.
>
> Tejesh R has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Add image capture on failure
>  - Review fix

It looks I didn't post my comments when I reviewed it.

test/jdk/java/awt/Frame/FrameLocation/FrameLocation.java line 33:

> 31: 
> 32: import javax.imageio.ImageIO;
> 33: import java.awt.Dimension;

We haven't agreed on the order of imports, yet usually `javax.*` packages go after `java.*` packages.

test/jdk/java/awt/Frame/FrameLocation/FrameLocation.java line 55:

> 53:                 f.setBounds(X, Y, 250, 250); // the size doesn't matter
> 54:                 f.setVisible(true);
> 55:             });

Why do you preserve `invokeAndWait` if the test passes without it?

-------------

PR Review: https://git.openjdk.org/jdk/pull/27366#pullrequestreview-3257459199
PR Review Comment: https://git.openjdk.org/jdk/pull/27366#discussion_r2371967577
PR Review Comment: https://git.openjdk.org/jdk/pull/27366#discussion_r2371970791


More information about the client-libs-dev mailing list