RFR: 8376627: Remove AppContext from javax/swing/plaf/metal classes [v2]

Phil Race prr at openjdk.org
Mon Feb 2 20:24:12 UTC 2026


On Thu, 29 Jan 2026 00:01:24 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8376627
>
> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBumps.java line 52:
> 
>> 50:     protected Color backColor;
>> 51: 
>> 52:     private static final List<BumpBuffer> BUMPS_LIST = new ArrayList<BumpBuffer>();
> 
> This doesn’t seem to be a constant, does it? I think at some point we should implement some kind of cleanup logic for this list.

The list is constant. The contents are added to.
I suppose (some day) something like a soft ref could be used, but I am not sure that there will ever be stale members to make it worthwhile or appropriate.
Either way, out of scope for this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29474#discussion_r2756014560


More information about the client-libs-dev mailing list